-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The big clean up #32
The big clean up #32
Conversation
daviddias
commented
Feb 1, 2016
Let scrutiny begin @RichardLitt @noffle @dignifiedquire can you CR the code please? After finishing here, I'll bring https://github.com/diasdavid/registry-static to be part of the project instead of a dependency that gets run as a shell command, so that I can get more interesting stats and control of what it is doing. |
There is a note on the README important to be able to run the tests https://github.com/diasdavid/registry-mirror/tree/refactor/the-big-clean-up#development |
Will check! |
I don't understand; what does this PR do? |
@diasdavid left some preliminary comments. Also travis is unhappy |
@diasdavid: could we get some more context? What are the high-level goals of this refactor? |
@dignifiedquire thank you for the CR, I've pushed changes following you comments :) @RichardLitt @noffle Apologies for not being clear, this PR is the transformation of registry-mirror from a collection of hacks and glue to it all work to a more structured code base, where there is order, making contribution and debugging easier |
@dignifiedquire travis is unhappy due to the missing 0.4.0 binary :) |
Will move ahead and merge this one, to be able to go to the next step, merge registry-static into the mix :) |